Fixed test cases for concurrent search #11119

e-emoto · 2023-11-06T23:46:11Z

Description

This makes use of the indexRandomForConcurrentSearch function, which creates more segments for concurrent search tests, in several test cases for their concurrent search use-cases. The following test suites are affected by this change:

DerivativeIT.java
MovAvgIT.java
SearchRedStateIndexIT.java
SearchWhileCreatingIndexIT.java
~~TransportTwoNodesSearchIT.java~~
RandomScoreFunctionIT.java
GeoFilterIT.java
MoreLikeThisIT.java
FetchSubPhasePluginIT.java

Related Issues

Resolves [BUG] FetchSubPhasePluginIT.testPlugin for concurrent search is flaky #11112
Resolves [BUG] RandomScoreFunctionIT.testConsistentHitsWithSameSeed for concurrent search is flaky #11106

Check List

New functionality includes testing.
- All tests pass
~~New functionality has been documented.~~
- ~~New functionality has javadoc added~~
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
~~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~~
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

server/src/internalClusterTest/java/org/opensearch/search/basic/TransportTwoNodesSearchIT.java

github-actions · 2023-11-07T00:22:04Z

Compatibility status:

Checks if related components are compatible with change e9ad245

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

github-actions · 2023-11-07T00:31:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29636/
CommitID: 287100c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

neetikasinghal · 2023-11-07T00:38:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/29636/

CommitID: 287100c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - this test is failing, is this flaky can you take a look at it and confirm if it is flaky or is it always failing?
if it is flaky, lets mute the test and create a corresponding issue.

e-emoto · 2023-11-07T00:44:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/29636/

CommitID: 287100c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - this test is failing, is this flaky can you take a look at it and confirm if it is flaky or is it always failing? if it is flaky, lets mute the test and create a corresponding issue.

This test was always failing, I forgot to remove indexRandomForConcurrentSearch from it

github-actions · 2023-11-07T00:45:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29640/
CommitID: 81c61b3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-07T01:35:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29647/
CommitID: efd0323
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-07T01:44:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29648/
CommitID: 3419d35
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-07T21:19:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29686/
CommitID: 3cb0ac0
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-07T22:03:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29687/
CommitID: 67f0fc3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

neetikasinghal · 2023-11-08T00:09:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/29687/

CommitID: 67f0fc3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - is this flaky?

jed326 · 2023-11-08T00:17:55Z

Flaky test

https://build.ci.opensearch.org/job/gradle-check/29687/

[BUG] Flaky test failure IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex #6124

github-actions · 2023-11-08T00:48:28Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29699/
CommitID: bf71dfd
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-08T01:12:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

URL: https://build.ci.opensearch.org/job/gradle-check/29698/
CommitID: 60bf49a
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-11-08T01:14:11Z

Codecov Report

Merging #11119 (e9ad245) into main (3bbc495) will decrease coverage by 0.12%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #11119      +/-   ##
============================================
- Coverage     71.25%   71.13%   -0.12%     
+ Complexity    58820    58781      -39     
============================================
  Files          4883     4883              
  Lines        277139   277139              
  Branches      40284    40284              
============================================
- Hits         197484   197155     -329     
- Misses        63204    63536     +332     
+ Partials      16451    16448       -3

see 474 files with indirect coverage changes

Fixed test cases Updated fix for TransportTwoNodesSearchIT test cases Updated test cases and muted flaky tests Move indexRandomForConcurrentSearch call into prepareData Remove changes from TransportTwoNodesSearchIT.java until future fix Signed-off-by: Ethan Emoto <eemoto@amazon.com>

github-actions · 2023-11-08T02:32:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/29701/
CommitID: e9ad245

Fixed test cases Updated fix for TransportTwoNodesSearchIT test cases Updated test cases and muted flaky tests Move indexRandomForConcurrentSearch call into prepareData Remove changes from TransportTwoNodesSearchIT.java until future fix Signed-off-by: Ethan Emoto <eemoto@amazon.com> (cherry picked from commit ff3a6a3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fixed test cases Updated fix for TransportTwoNodesSearchIT test cases Updated test cases and muted flaky tests Move indexRandomForConcurrentSearch call into prepareData Remove changes from TransportTwoNodesSearchIT.java until future fix (cherry picked from commit ff3a6a3) Signed-off-by: Ethan Emoto <eemoto@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fixed test cases Updated fix for TransportTwoNodesSearchIT test cases Updated test cases and muted flaky tests Move indexRandomForConcurrentSearch call into prepareData Remove changes from TransportTwoNodesSearchIT.java until future fix Signed-off-by: Ethan Emoto <eemoto@amazon.com>

Fixed test cases Updated fix for TransportTwoNodesSearchIT test cases Updated test cases and muted flaky tests Move indexRandomForConcurrentSearch call into prepareData Remove changes from TransportTwoNodesSearchIT.java until future fix Signed-off-by: Ethan Emoto <eemoto@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

neetikasinghal added the skip-changelog label Nov 6, 2023

neetikasinghal reviewed Nov 6, 2023

View reviewed changes

server/src/internalClusterTest/java/org/opensearch/search/basic/TransportTwoNodesSearchIT.java Outdated Show resolved Hide resolved

neetikasinghal mentioned this pull request Nov 6, 2023

Fix tests running with slice count of 1 for concurrent search use-case #11120

Closed

5 tasks

e-emoto force-pushed the test-changes branch from efd0323 to 3419d35 Compare November 7, 2023 00:53

e-emoto force-pushed the test-changes branch from 3cb0ac0 to 67f0fc3 Compare November 7, 2023 21:15

e-emoto force-pushed the test-changes branch 2 times, most recently from 60bf49a to bf71dfd Compare November 8, 2023 00:45

e-emoto force-pushed the test-changes branch from bf71dfd to e9ad245 Compare November 8, 2023 01:42

github-actions bot added the bug Something isn't working label Nov 8, 2023

peternied approved these changes Nov 8, 2023

View reviewed changes

peternied merged commit ff3a6a3 into opensearch-project:main Nov 8, 2023
32 checks passed

jed326 added the backport 2.x Backport to 2.x branch label Nov 8, 2023

opensearch-trigger-bot bot mentioned this pull request Nov 8, 2023

[Backport 2.x] Fixed test cases for concurrent search #11137

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed test cases for concurrent search #11119

Fixed test cases for concurrent search #11119

e-emoto commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023

neetikasinghal commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

e-emoto commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

neetikasinghal commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

jed326 commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

codecov bot commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023

Fixed test cases for concurrent search #11119

Fixed test cases for concurrent search #11119

Conversation

e-emoto commented Nov 6, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Nov 7, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

neetikasinghal commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

e-emoto commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

neetikasinghal commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

jed326 commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Nov 8, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

e-emoto commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading